Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to random UUID if no id contributing properties in the result #990

Merged
merged 2 commits into from
Jun 21, 2022

Conversation

delliott90
Copy link
Collaborator

Fallback to random UUID if STIX 2.1 object definition has ID contributing properties but the results have no data for those properties.

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #990 (28a348b) into develop (3c522d9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #990   +/-   ##
========================================
  Coverage    64.73%   64.73%           
========================================
  Files          517      517           
  Lines        48876    48878    +2     
========================================
+ Hits         31639    31641    +2     
  Misses       17237    17237           
Impacted Files Coverage Δ
...lation/src/json_to_stix/json_to_stix_translator.py 78.27% <100.00%> (+0.06%) ⬆️
tests/stix_translation/test_results_translation.py 67.50% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c522d9...28a348b. Read the comment docs.

@delliott90 delliott90 merged commit 77a4093 into develop Jun 21, 2022
@delliott90 delliott90 deleted the deterministic_id_fix branch June 21, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants